Fix RTCPeerConnection-transceivers.https.html bug. #12237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 30, 2018
This PR accidentally made the "addTrack(0 streams)" test call addTrack() with a stream, which broke the tests: #12141 Test restored and all "addTrack/addTransceiver(X streams)" are made to consistently use "new MediaStream()" the same way. Bug: 869036 Change-Id: Ieaf0c73a1996aeb2e87e18f2f9065fa1e6fee1e7 Reviewed-on: https://chromium-review.googlesource.com/1155125 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Henrik Boström <[email protected]> Cr-Commit-Position: refs/heads/master@{#579341}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1155125
branch
from
d92cd14
to
84b5c72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accidentally made the "addTrack(0 streams)" test call addTrack()
with a stream, which broke the tests:
#12141
Test restored and all "addTrack/addTransceiver(X streams)" are made to
consistently use "new MediaStream()" the same way.
Bug: 869036
Change-Id: Ieaf0c73a1996aeb2e87e18f2f9065fa1e6fee1e7
Reviewed-on: https://chromium-review.googlesource.com/1155125
Reviewed-by: Harald Alvestrand [email protected]
Commit-Queue: Henrik Boström [email protected]
Cr-Commit-Position: refs/heads/master@{#579341}